Type hint transformation for sealed hierarchies #1093
Merged
+247
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirkl
force-pushed
the
json-hint-names
branch
from
6182791 to
c8cc378
Compare
jdegoes
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds support for transforming type hint values in sealed hierarchies using same approach as for
@jsonMemberNames- via new annotation@jsonHintNamesfor sealed class / trait. This approach looks more maintainable than individual@jsonHintfor each descendent, especially when supporting some naming convention in large hierarchy.I also noticed similar feature request in discord, so I hope this PR will be useful not only for me: https://discord.com/channels/629491597070827530/733728086637412422/1221797252432007290